irods / irods_client_nfsrods

An nfs4j Virtual File System implementation supporting the iRODS Data Grid
BSD 3-Clause "New" or "Revised" License
8 stars 9 forks source link

Make NFSRODS work when restarting NFSRODS without remounting #182

Closed ganning127 closed 9 months ago

ganning127 commented 12 months ago

changes made

korydraughn commented 12 months ago

Consider squashing now so no one is confused by the didn't mean to delete code commit.

ganning127 commented 12 months ago

squashed!

ganning127 commented 11 months ago

the small timeout issue right now, is that if you run docker restart nfsrods, and then run a command like ls immediately after (like without giving the NFSRODS instance a second or so), NFSRODS will output a short error message, before coming alive again.

$ docker restart nfsrods
nfsrods
$ ls
nfs server localhost:/: not responding
nfs server localhost:/: is alive again
anotherFolder                            dave.txt                                 lightsssss.txt
asdfasdfasd.txt                          daveFolder                               macBookPro.txt
aslkdfjalksjfasdjfakasfljkasdfjlkadf.txt davvvvvveee.txt                          newBrah.txt
bar.txt                                  eagle.txt                                newFileGanning.txt
booobooo.tasdfas                         foo.txt                                  stuffs
coocoo.txt                               grrr.txt                                 testFolder
daaaaa.txt                               laksdfljkas.txt
ganning127 commented 11 months ago

however, viewing, listing, and editing files all work as normal now after doing restart without re-mounting

trel commented 11 months ago

oh... this is very cool.

that error message is the 'client side' printing that out - and it's due to the NFSRODS server not responding fast enough. not sure there's anything we can do about that except eventually work to optimize startup time (a bit out of our control as we're just providing the virtual filesystem backend to the NFS4J server framework).

trel commented 11 months ago

the next pass through the code, please remove all the deadcode and consider some comments for 'why' you're adding the things you've added. please send flare for when you want eyeballs/comments on the code itself.

good stuff.

trel commented 11 months ago

looking very good - need some @korydraughn eyeballs before squashing.

korydraughn commented 11 months ago

Will look as soon as I can.

ganning127 commented 11 months ago

Just leaving this here for reference. We're having some inconsistencies with some tests failing on Linux but not on macOS. Specific details are in this new issue: #187