search

irods / irods_client_nfsrods

An nfs4j Virtual File System implementation supporting the iRODS Data Grid
BSD 3-Clause "New" or "Revised" License
8 stars 9 forks source link

[#205] Add iRODS server version check to resize operation #206

Closed korydraughn closed 1 month ago

korydraughn commented 1 month ago

This PR originally logged a warning on server startup about the replica truncate API not being supported. That approach was dropped due to NFSRODS becoming unresponsive after attempting to invoke the replica truncate API on a 4.3.1 server.

I've updated the code to check if replica truncate is supported before attempting to invoke it. If the API is not supported, an exception will be thrown. Throwing an exception is important because it lets the user know things didn't work. This approach also allows NFSRODS to remain compatible with earlier versions of iRODS.

The first commit contains the original work. Those changes will be reverted following the squash.

trel commented 1 month ago

okay - so just an exception when it happens. no warning on startup.

so all we need more is a note in the README?

korydraughn commented 1 month ago

Added note to README.

trel commented 1 month ago

looks good - surgical.

squash em.

korydraughn commented 1 month ago

Squashed w/o pound.

korydraughn commented 1 month ago

So a client connected to NFS will just see an 'I/O Error'... and the NFSRODS admin would see 'why' in the NFSRODS log.

Correct.

'd