Open JustinKyleJames opened 3 weeks ago
Code change looks good.
Is it possible to write a test for this?
It is but I don't believe I have any tests for AbortMultipartUpload
at the moment. I can add a test to do exactly what was causing the problem before.
Once ListParts
and ListMultipartUploads
are implemented I will able to have better tests.
Yes, add a test which shows that the thing which triggered the issue is now resolved.
We'll merge this once that's added.
I added a test case to test the scenario that was failing. I verified that the new test case passes with the code change and fails without the code change.
Is this ready to be squashed? I know Alan stated it was but there were more review comments/changes after that.
If the work has been completed, please squash it.
I do not see the new changes yet. Perhaps they have not been pushed?
This is to fix issue 130.
All tests passed.