irods / irods_python_ci_utilities

1 stars 7 forks source link

`yum update -y` breaks plugin testing for 4.2.12 #22

Open korydraughn opened 1 year ago

korydraughn commented 1 year ago

The following line causes the iRODS 4.2.12 server packages to be upgraded to 4.3.x.

https://github.com/irods/irods_python_ci_utilities/blob/e662991f03caa043ce569cda83b807c237b64870/irods_python_ci_utilities/irods_python_ci_utilities.py#L119

This makes it impossible to test CentOS 7 plugins using the run_plugin_tests.py script of the testing environment. Below is a snippet of the output captured from the testing environment.

Error: Package: irods-rule-engine-plugin-unified-storage-tiering-4.2.12.0-1.x86_64 (/irods-rule-engine-plugin-unified-storage-tiering-4.2.12.0-1.x86_64)                                      
           Requires: irods-runtime = 4.2.12                                                                                                                                                   
           Installed: irods-runtime-4.3.1-0.el7.x86_64 (@renci-irods)                                                                                                                                                                                                                                                                                                                        
               irods-runtime = 4.3.1-0.el7                                                                                                                                                    
           Available: irods-runtime-4.2.0-1.x86_64 (renci-irods)                               
               irods-runtime = 4.2.0-1                                          
           Available: irods-runtime-4.2.1-1.x86_64 (renci-irods)                                                                                                                                                                                                                                                                                                                             
               irods-runtime = 4.2.1-1                                                                                                                                                        
           Available: irods-runtime-4.2.2-1.x86_64 (renci-irods)                               
               irods-runtime = 4.2.2-1                                                                                                                                                                                                                                                                                                                                                                  Available: irods-runtime-4.2.3-1.x86_64 (renci-irods)                                                                                                                              
               irods-runtime = 4.2.3-1                                                                                                                                                                                                                                                                                                                                                       
           Available: irods-runtime-4.2.4-1.x86_64 (renci-irods)                            
               irods-runtime = 4.2.4-1                                                                                                                                                                                                                                                                                                                                                       
           Available: irods-runtime-4.2.5-1.x86_64 (renci-irods)                               
               irods-runtime = 4.2.5-1                                          
           Available: irods-runtime-4.2.6-1.x86_64 (renci-irods)                                                                                                                              
               irods-runtime = 4.2.6-1                                                                                                                                                        
           Available: irods-runtime-4.2.7-1.x86_64 (renci-irods)                
               irods-runtime = 4.2.7-1                                                                                                                                                                                                                                                                                                                                                       
           Available: irods-runtime-4.2.8-1.x86_64 (renci-irods)                                                                                                                              
               irods-runtime = 4.2.8-1                                                                                                                                                        
           Available: irods-runtime-4.2.9-1.x86_64 (renci-irods)                                                                                                                              
               irods-runtime = 4.2.9-1                                                                                                                                                        
           Available: irods-runtime-4.2.10-1.x86_64 (renci-irods)                                                                                                                             
               irods-runtime = 4.2.10-1                                                                                                                                                                                                                                                                                                                                                      
           Available: irods-runtime-4.2.11-1.x86_64 (renci-irods)                                                                                                                                                                                                                                                                                                                            
               irods-runtime = 4.2.11-1                                                                                                                                                                                                                                                                                                                                                      
           Available: irods-runtime-4.2.12-1.x86_64 (renci-irods)                                                                                                                             
               irods-runtime = 4.2.12-1                                                        
           Available: irods-runtime-4.3.0-1.x86_64 (renci-irods)                  
               irods-runtime = 4.3.0-1                                                         
Error: Package: irods-rule-engine-plugin-unified-storage-tiering-4.2.12.0-1.x86_64 (/irods-rule-engine-plugin-unified-storage-tiering-4.2.12.0-1.x86_64)                                      
           Requires: irods-server = 4.2.12                                                     
           Installed: irods-server-4.3.1-0.el7.x86_64 (@renci-irods)                                                                                                                          
               irods-server = 4.3.1-0.el7                                                      
           Available: irods-server-4.2.0-1.x86_64 (renci-irods)               
               irods-server = 4.2.0-1                                                          
           Available: irods-server-4.2.1-1.x86_64 (renci-irods)                                                                                                                               
               irods-server = 4.2.1-1                                           
           Available: irods-server-4.2.2-1.x86_64 (renci-irods)                                                                                                                               
               irods-server = 4.2.2-1
           Available: irods-server-4.2.3-1.x86_64 (renci-irods)
               irods-server = 4.2.3-1
           Available: irods-server-4.2.4-1.x86_64 (renci-irods)
               irods-server = 4.2.4-1
           Available: irods-server-4.2.5-1.x86_64 (renci-irods)
               irods-server = 4.2.5-1
           Available: irods-server-4.2.6-1.x86_64 (renci-irods)
               irods-server =
2023-11-10 08:49:47,949 -  4.2.6-1
           Available: irods-server-4.2.7-1.x86_64 (renci-irods)
               irods-server = 4.2.7-1
           Available: irods-server-4.2.8-1.x86_64 (renci-irods)
               irods-server = 4.2.8-1
           Available: irods-server-4.2.9-1.x86_64 (renci-irods)
               irods-server = 4.2.9-1
           Available: irods-server-4.2.10-1.x86_64 (renci-irods)
               irods-server = 4.2.10-1
           Available: irods-server-4.2.11-1.x86_64 (renci-irods)
               irods-server = 4.2.11-1
           Available: irods-server-4.2.12-1.x86_64 (renci-irods)
               irods-server = 4.2.12-1
           Available: irods-server-4.3.0-1.x86_64 (renci-irods)
               irods-server = 4.3.0-1

2023-11-10 08:49:47,949 - Traceback (most recent call last):
  File "/home/kory/dev/prog/cpp/irods_capability_storage_tiering/irods_consortium_continuous_integration_test_hook.py", line 47, in <module>
    main()
  File "/home/kory/dev/prog/cpp/irods_capability_storage_tiering/irods_consortium_continuous_integration_test_hook.py", line 27, in main

2023-11-10 08:49:47,949 -     'irods-rule-engine-plugin-unified-storage-tiering*.{}'.format(package_suffix))
  File "/usr/lib/python2.7/site-packages/irods_python_ci_utilities/irods_python_ci_utilities.py", line 139, in install_os_packages_from_files

2023-11-10 08:49:47,950 -     dispatch_map[get_distribution()](files)
  File "/usr/lib/python2.7/site-packages/irods_python_ci_utilities/irods_python_ci_utilities.py", line 121, in install_os_packages_from_files_yum
    subprocess_get_output(args, check_rc=True)
  File "/usr/lib/python2.7/site-packages/irods_python_ci_utilities/irods_python_ci_utilities.py", line 70, in subprocess_get_outpu

The logic for handling apt-based packaging systems does not perform an update/upgrade. We should investigate the removal of the yum update -y command for CentOS 7.

The workaround for this is manual testing.

alanking commented 1 year ago

I've definitely hit this before but I don't quite remember when or how or whether I got around it. Probably should just be rid of it, yes

korydraughn commented 1 year ago

I agree. I think removing the update step is safe since only the plugins rely on the ci utilities scripts.