search

irods / irods_resource_plugin_rados

Cacheless Ceph/rados resource plugin for iRODS
BSD 3-Clause "New" or "Revised" License
7 stars 6 forks source link

cmakelists: make install plugin to correct plugins destination #8

Closed kwaegema closed 6 years ago

kwaegema commented 6 years ago

fixes #5

kwaegema commented 6 years ago

I changed it to use ${IRODS_PLUGINS_DIRECTORY}. But as seen in https://github.com/irods/irods/blob/5ee1bf6b711abdd07b8ccc1d021dc19e270fb7a4/CMakeLists.txt#L1298 , this is also relative. So make install put the files in /usr/local/.. again, which probably is the default. However, make package generates an rpm with the file in the correct place, which is probably the way to go anyway 😄

trel commented 6 years ago

Yes, it is relative because the IRODS_INSTALL_DIR is also a variable.

https://docs.irods.org/master/getting_started/installation/#non-package-install-run-in-place

In a normal packaged configuration, the IRODS_INSTALL_DIR is defined to /. And then all paths are relative to that (hence the usr/lib/... with no leading slash).

In a Non-Package Install configuration, the IRODS_INSTALL_DIR is defined by the user at build time, and the plugins should honor that setting.