search

irods / irods_resource_plugin_s3

S3-compatible storage resource plugin for iRODS
Other
12 stars 16 forks source link

[#2156] Replace variable length arrays with `alloca()` (4-3-stable) #2182

Closed SwooshyCueb closed 3 months ago

SwooshyCueb commented 6 months ago

Addresses #2156 (for real this time)

SwooshyCueb commented 3 months ago

#'d

korydraughn commented 3 months ago

4-3-stable relies on libc++. Was main tested using libstdc++ or libc++?

I noticed the comment about VLAs crashing clang in the cmake. Is that something we need to worry about for this branch?

SwooshyCueb commented 3 months ago

4-3-stable relies on libc++. Was main tested using libstdc++ or libc++?

I tested with libstdc++ on main, libc++ on stable.

I noticed the comment about VLAs crashing clang in the cmake. Is that something we need to worry about for this branch?

There's no difference between the two branches that affects clang's tendency to crash when compiling source code that contains VLAs.