search

irods / irods_resource_plugin_s3

S3-compatible storage resource plugin for iRODS
Other
12 stars 16 forks source link

Upgrade of pip in test hook breaks tests #2212

Closed FifthPotato closed 2 weeks ago

FifthPotato commented 3 weeks ago

Trying to upgrade pip causes a test failure in ubuntu 24. The following line is the cause, but it might not be able to be deleted since other OSes might need it. https://github.com/irods/irods_resource_plugin_s3/blob/0304827fea9a4a8acfc6c68b18c69ae165a9dedd/irods_consortium_continuous_integration_test_hook.py#L36

Maybe a solution would be to sniff the OS first and avoid it on ubuntu24?

alanking commented 3 weeks ago

Can you share the specific error that occurs? Do things start working when you do not upgrade pip for Ubuntu 24?

FifthPotato commented 3 weeks ago

Can you share the specific error that occurs? Do things start working when you do not upgrade pip for Ubuntu 24?

I think the relevant lines are as follows:

2024-08-19 21:15:53,331 - RuntimeError: subprocess_get_output() failed                                                         
args: (['sudo', 'python3', '-m', 'pip', 'install', '--upgrade', 'pip>=20.3.4'],)                                               
kwargs: {'stdout': -1, 'stderr': -1}                                                                                           
returncode: 1                                                                                                                  
stdout: Requirement already satisfied: pip>=20.3.4 in /usr/lib/python3/dist-packages (24.0)                                    
Collecting pip>=20.3.4                                                                                                         
  Downloading pip-24.2-py3-none-any.whl.metadata (3.6 kB)                                                                      
Downloading pip-24.2-py3-none-any.whl (1.8 MB)                                                                                 
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.8/1.8 MB 19.2 MB/s eta 0:00:00                                                   
Installing collected packages: pip                                                                                             
  Attempting uninstall: pip                                                                                                    
    Found existing installation: pip 24.0                                                                                      

stderr: ERROR: Cannot uninstall pip 24.0, RECORD file not found. Hint: The package was installed by debian.

And yes, things do start working when I delete this line from the test hook.

alanking commented 2 weeks ago

@FifthPotato - Please checkbox and close. Thanks