search

irods / irods_rule_engine_plugin_audit_amqp

BSD 3-Clause "New" or "Revised" License
2 stars 14 forks source link

iCommands return `CLIENT_NEGOTIATION_ERROR` when `".*"` is used as the regular expression to match #124

Closed korydraughn closed 4 months ago

korydraughn commented 11 months ago

This was observed while manually testing the audit plugin (510f53e) for what will most likely be iRODS 4.3.1 (irods/irods/tree/97eb33f). The OS was Ubuntu 20.04.

To reproduce, stand up a rabbitmq:3-management docker container (available via docker hub), make the audit plugin's regex ".*", and then execute ils.

The weird part is the issues go away if "pep.*" or any regex other than ".*" is used.

SwooshyCueb commented 11 months ago

I'm curious, have you tried .+?

korydraughn commented 11 months ago

I haven't. Will give that a try tomorrow.

korydraughn commented 11 months ago

It resulted in the same error.

trel commented 11 months ago

do any messages make it to the broker? wondering what else it is matching that is clogging up the server...

korydraughn commented 11 months ago

Yes. I originally thought it could be a data type that the audit plugin didn't understand, but the serialization logic has that case covered.

trel commented 11 months ago

and all the messages that make it to the broker start with pep_?

korydraughn commented 11 months ago

I didn't check that. There are a lot of messages in there and I never figured out how to access them via the command line. The GUI is very limited. I didn't see a way to easily check the contents of the messages because they're all base64 encoded.

The messages I did decode looked fine on a structural level.

trel commented 11 months ago

Okay, we'll investigate more after release.

korydraughn commented 4 months ago

I have not been able to reproduce this using the 4.3.1.0 or 4.3.2.0 plugins. All reported PEPs are being captured as expected. The icommands are not experiencing errors.

Everything is working as expected. Closing.