irods / irods_rule_engine_plugin_audit_amqp

BSD 3-Clause "New" or "Revised" License
2 stars 14 forks source link

Add Rocky Linux to build hook (main) #125

Closed korydraughn closed 11 months ago

korydraughn commented 11 months ago

It's not clear to me why we need the audit_ namespace. The slides include it, but don't explain why.

Perhaps it's for demonstration purposes?

peterverraedt commented 11 months ago

I guess the audit namespace and the regexp example "audit.*" are there to avoid the scenario that the audit rule engine plugin is put first in the list, above the "native" rule engines that need to handle certain peps (e.g. at startup of irods), and would fire on any pep. Otherwise the audit rule plugin would consume these peps and because it lacks RULE_ENGINE_CONTINUE, the native rule engines would not be able to act upon the peps.

Putting no namespace and no audit_ prefix in the regexp, works fine as long as the regexp does not match certain acXXXX peps or is listed below the native rule engine. Ideally, the audit plugin should return RULE_ENGINE_CONTINUE so that it does not matter where it is put in the rule engine list.

trel commented 11 months ago

RULE_ENGINE_CONTINUE

This is very true. This rule engine plugin was written before we had the concept of RULE_ENGINE_CONTINUE and I bet does explain the different namespacing that was created.

korydraughn commented 11 months ago

Created #126 to address the RULE_ENGINE_CONTINUE case.