search

irods / irods_rule_engine_plugin_audit_amqp

BSD 3-Clause "New" or "Revised" License
2 stars 14 forks source link

[irods/irods#7220] Do not explicitly build against libc++ #133

Closed SwooshyCueb closed 6 months ago

SwooshyCueb commented 7 months ago

In service of irods/irods#7220

Merge irods/irods#7526 before merging this.

SwooshyCueb commented 6 months ago

#'d

SwooshyCueb commented 6 months ago

Do we need to keep the libcxx option around, or are we just moving ahead in the plugins?

I wasn't planning on supporting it in the plugins

korydraughn commented 6 months ago

I had a similar thought about whether the build/test hooks needed additional options, but because this is targeting the main branch, I think it's fine. We can always adjust the hooks later too.

I take it the 4-3-stable branch's build/test hooks will be updated to list the libcxx variants instead?

SwooshyCueb commented 6 months ago

I take it the 4-3-stable branch's build/test hooks will be updated to list the libcxx variants instead?

You've already approved the PR for it.

korydraughn commented 6 months ago

Just looked at the 4-3-stable branch and they are what I expected.

You've already approved the PR for it.

Yep.