search

irods / irods_rule_engine_plugin_logical_quotas

BSD 3-Clause "New" or "Revised" License
1 stars 9 forks source link

Plugin does not crash agent on unsupported rule text (main) #88

Closed korydraughn closed 1 year ago

korydraughn commented 1 year ago

Adapted from #87.

All tests pass.

korydraughn commented 1 year ago

Ignoring the clang-format gh workflow results for now.

Will handle that once @d-w-moore's PR is merged.

korydraughn commented 1 year ago

Codacy doesn't seem to be analyzing this repo.

We should either remove it or make it so that it can do its job.

trel commented 1 year ago

hmm, looking.

trel commented 1 year ago

it was not looking at 'main' since the rename. should now trigger codacy.

korydraughn commented 1 year ago

Everything looks good to me. Holding off til #85 is merged?

No. We can go ahead and get this merged.

I'm planning on formatting the entire code base once @d-w-moore's PR is merged. That'll happen in a separate PR.

korydraughn commented 1 year ago

Added #'s