irods / irods_rule_engine_plugin_logical_quotas

BSD 3-Clause "New" or "Revised" License
1 stars 9 forks source link

[#84] use admin flag to change AVUs when recalculating totals (main) #89

Closed d-w-moore closed 1 year ago

d-w-moore commented 1 year ago

Cherry-picked from https://github.com/irods/irods_rule_engine_plugin_logical_quotas/pull/85

d-w-moore commented 1 year ago

All tests pass except :

irods.test.test_rule_engine_plugin_logical_quotas.Test_Rule_Engine_Plugin_Logical_Quotas.test_group_owned_collections_do_not_require_the_admin_to_manually_change_acls__issue_35 ...

... but that test also fails on current tip of main without these changes applied.

korydraughn commented 1 year ago

Ignore clang-format for now.

Capture that failing test in an issue and we'll handle it later. 4.2.12 is the priority.

Do all of the other tests still pass?

d-w-moore commented 1 year ago

Do all of the other tests still pass?

Yes, all other tests passing at the bench.

korydraughn commented 1 year ago

Please ignore the clang-format workflow. The config is correct, but we'll address the formatting in a separate PR.

Please revert or drop the commits for clang-format if possible.

korydraughn commented 1 year ago

Please squash if you're happy with the changes and everything works.

d-w-moore commented 1 year ago

Well, so.... maybe not happy quite yet. My local git clang-format apparently does not jib with something in GitHub. Will require a tutorial later, I imagine.

korydraughn commented 1 year ago

That's fine. Ignore clang-format for now.

korydraughn commented 1 year ago

Squash and we'll look over it one more time.

d-w-moore commented 1 year ago

ok, squashed!

d-w-moore commented 1 year ago

Should I first cut-paste and apply the diff out of the failed clang-format section above ? Or do we merge with formatting not satisfied?

korydraughn commented 1 year ago

Ignore the clang-format for this PR.

We'll handle that in a separate PR.

d-w-moore commented 1 year ago

# added