Closed d-w-moore closed 1 year ago
All tests pass except :
irods.test.test_rule_engine_plugin_logical_quotas.Test_Rule_Engine_Plugin_Logical_Quotas.test_group_owned_collections_do_not_require_the_admin_to_manually_change_acls__issue_35 ...
... but that test also fails on current tip of main without these changes applied.
Ignore clang-format for now.
Capture that failing test in an issue and we'll handle it later. 4.2.12 is the priority.
Do all of the other tests still pass?
Do all of the other tests still pass?
Yes, all other tests passing at the bench.
Please ignore the clang-format workflow. The config is correct, but we'll address the formatting in a separate PR.
Please revert or drop the commits for clang-format if possible.
Please squash if you're happy with the changes and everything works.
Well, so.... maybe not happy quite yet. My local git clang-format
apparently does not jib with something in GitHub. Will require a tutorial later, I imagine.
That's fine. Ignore clang-format for now.
Squash and we'll look over it one more time.
ok, squashed!
Should I first cut-paste and apply the diff out of the failed clang-format section above ? Or do we merge with formatting not satisfied?
Ignore the clang-format for this PR.
We'll handle that in a separate PR.
#
added
Cherry-picked from https://github.com/irods/irods_rule_engine_plugin_logical_quotas/pull/85