search

irods / irods_rule_engine_plugin_metadata_guard

BSD 3-Clause "New" or "Revised" License
0 stars 7 forks source link

Preventing imeta mod bypass #69

Closed FifthPotato closed 8 months ago

FifthPotato commented 8 months ago

Seems to work so far. Need to do a bit more research to figure out if there are any other cases I missed.

Need to write tests, too.

trel commented 8 months ago

this is to address #58?

trel commented 8 months ago

good so far - let's get a couple tests in today.

korydraughn commented 8 months ago

All we need now are the tests and we're good to go.

FifthPotato commented 8 months ago

Added test, and force-pushed because I forgot to update main on my repo after my last PR.

korydraughn commented 8 months ago

Don't forget to mark comments resolved as you complete them.

FifthPotato commented 8 months ago

Tests pass.

korydraughn commented 8 months ago

Good. Please squash to taste, no #'s

FifthPotato commented 8 months ago

Squashed

korydraughn commented 8 months ago

Let's adjust the commit message so that it isn't specific to imeta. How about ...

[58] Do not allow renaming non-protected AVU to existing protected AVU.

Looking at the test again, it appears we're missing tests which prove imeta mod <protected_avu> <protected_avu> is covered.

I'll write up an issue for that. We can add tests in a later PR.

FifthPotato commented 8 months ago

Amended!

FifthPotato commented 8 months ago

Octothorpe'd

korydraughn commented 8 months ago

Please cherry-pick to the 4-3-stable branch, no #'s.

korydraughn commented 8 months ago

@FifthPotato ping!