search

irods / irods_rule_engine_plugin_python

BSD 3-Clause "New" or "Revised" License
10 stars 14 forks source link

GeneralUpdate structs generate deprecation warnings during build #196

Closed alanking closed 7 months ago

alanking commented 7 months ago

GeneralUpdate was deprecated in irods/irods#7554 and now deprecation warnings are being emitted when building this plugin:

stderr: In file included from /irods_plugin_source/src/irods_types.cpp:13:    
/irods_plugin_source/include/irods/private/re/python/irods_types.hpp:77:2: error: 'generalUpdateInp_t' is deprecated: GeneralUpdate is deprecated. Its use should be avoided. [-Werror,-Wdeprecated-declarations]
        generalUpdateInp_t,                                                                                                                 
        ^                                                                                                                                   
/usr/include/irods/rodsGeneralUpdate.h:29:16: note: 'generalUpdateInp_t' has been explicitly marked deprecated here
__attribute__((deprecated("GeneralUpdate is deprecated. Its use should be avoided."))) typedef struct __attribute__((
               ^   
1 error generated.
make[2]: *** [CMakeFiles/irods_rule_engine_plugin-python.dir/build.make:104: CMakeFiles/irods_rule_engine_plugin-python.dir/src/irods_types.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from /irods_plugin_source/src/main.cpp:39:
In file included from /irods_plugin_source/include/irods/private/re/python.hpp:33:
/irods_plugin_source/include/irods/private/re/python/irods_types.hpp:77:2: error: 'generalUpdateInp_t' is deprecated: GeneralUpdate is deprecated. Its use should be avoided. [-Werror,-Wdeprecated-declarations]
        generalUpdateInp_t,
        ^   
/usr/include/irods/rodsGeneralUpdate.h:29:16: note: 'generalUpdateInp_t' has been explicitly marked deprecated here
__attribute__((deprecated("GeneralUpdate is deprecated. Its use should be avoided."))) typedef struct __attribute__((
               ^
1 error generated. 
make[2]: *** [CMakeFiles/irods_rule_engine_plugin-python.dir/build.make:76: CMakeFiles/irods_rule_engine_plugin-python.dir/src/main.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:83: CMakeFiles/irods_rule_engine_plugin-python.dir/all] Error 2
make: *** [Makefile:156: all] Error 2

We need to handle these.