search

irods / irods_rule_engine_plugin_python

BSD 3-Clause "New" or "Revised" License
10 stars 14 forks source link

[#217,#218] Remove Python 2 support code, implement proper thread state handling (4-3-stable) #220

Closed SwooshyCueb closed 1 month ago

SwooshyCueb commented 1 month ago

Addresses #217 Addresses #218 (WIP)

Not tested yet, could probably be improved.

Since I am currently testing with 4-3-stable, progress may be followed here instead of in #219.

SwooshyCueb commented 1 month ago

Ran the test suites for Ubuntu 22.04 and 24.04 and everything passed, so I'm marking this ready for review. Will squash and update the other PR tomorrow.

korydraughn commented 1 month ago

After some discussion, the plan is to see if testing passes for Ubuntu 20 before testing non-Ubuntu platforms.

If the tests pass for all platforms, then Ubuntu 24 and the PREP get a 4.3.3 release.

SwooshyCueb commented 1 month ago

Tests pass for Ubuntu 20.04. Commits squashed. If there are no objections, I will #.

korydraughn commented 1 month ago

Let's test the remaining platforms first just in case other tweaks are needed.

I'll pull your changes and start running tests.

korydraughn commented 1 month ago

Because python_thread_state_scope has changed (i.e. disabled copy/move semantics), please confirm test_icp.Test_Icp.test_multithreaded_icp__issue_5478 still passes with this PR.

I don't suspect anything to break, but we need to be sure.

SwooshyCueb commented 1 month ago

Because python_thread_state_scope has changed (i.e. disabled copy/move semantics), please confirm test_icp.Test_Icp.test_multithreaded_icp__issue_5478 still passes with this PR.

It still passes. Tested on Ubuntu 24.04 and 20.04.

SwooshyCueb commented 1 month ago

Please add words to the body of the commit message for #218 which explain what is being solved.

Done

SwooshyCueb commented 1 month ago

#'d