irods / irods_testing_environment

BSD 3-Clause "New" or "Revised" License
8 stars 15 forks source link

Running tests in 4-2-stable generates a lot of noise #124

Closed alanking closed 2 years ago

alanking commented 2 years ago

When running tests, we check what version of iRODS is running in a given container so that we can determine which version of python to use. The utility for checking the version pulls /var/lib/irods/version.json out of the container and reads the version string. This file is named /var/lib/irods/VERSION.json in versions <4.3.0. The result is an error message that looks like this for every test that is run:

404 Client Error for http+docker://localhost/v1.41/containers/647f1ce0c1f597e9ceb06c448dc41f2e1f600c7faefc5c12d3d13181808329ee/archive?path=%2Fvar%2Flib%2Firods%2Fversion.json.dist: Not Found ("Could not find the file /var/lib/irods/version.json.dist in container 647f1ce0c1f597e9ceb06c448dc41f2e1f600c7faefc5c12d3d13181808329ee")

We need to handle this more gracefully.

Additionally, we don't need to be checking this file on every single test run. The version should be checked once and saved in memory for the remainder of the time that the executing script is running.