search

irods / irods_testing_environment

BSD 3-Clause "New" or "Revised" License
8 stars 14 forks source link

Print SHA of project following test run #143

Open korydraughn opened 1 year ago

korydraughn commented 1 year ago

Enhancement

It would be nice if the testing environment printed the SHA of the project that was just tested. That would help developers know what code is being tested at all times. Especially for cases where a developer is doing a lot of multitasking.

Printing the SHA at the end of testing seems good. Also, it shouldn't matter if the test succeeded or failed.

alanking commented 1 year ago

I like this idea a lot and it's something I've thought about for a while as well. How would you like to present the information?

Here's an option that I implemented because it was the easiest. Each test runner presents its own version/sha:

2023-01-06 18:07:11,092 - ==== begin test run results ====
-----
results for [ubuntu-2004-postgres-1012_irods-catalog-provider_1]
        passed tests:
                [[   4.2582]s]  [test_iexit]
        skipped tests:
        failed tests:
        return code:[0]
        time elapsed: [    4.259]seconds ([   0]hours [  0.07099]minutes)
        version:[4.3.0]
        sha:[cb4f467914e8e618c6f19e33f910620d52f3fa30]
-----
All tests passed! :)
time elapsed: [   4.2609]seconds ([   0]hours [ 0.0710]minutes)
==== end of test run results ====

We could also show the version/sha for the whole run at the end.

korydraughn commented 1 year ago

I like all of that. Definitely the sha/version for the whole run.

I hadn't thought about showing it for individual runners, but that would help if/when we're able to run tests for setups involving different versions of iRODS.

trel commented 1 year ago

dumb questions incoming...

SHA of what? the commit of the iRODS core? any/all plugins? the plugin being tested/targeted?

korydraughn commented 1 year ago

Yes to all of that if possible.

The server code and icommands is top priority in my opinion since that undergoes testing more often than the plugins.

korydraughn commented 1 year ago

The short answer - the SHA of the code being tested.

alanking commented 1 year ago

I will leave this open for now because plugin tests need to extract the sha from the packages or something in order to show the sha of the code being tested.