search

irods / irods_testing_environment

BSD 3-Clause "New" or "Revised" License
8 stars 15 forks source link

Print iRODS sha/version and move database service check #145

Closed alanking closed 1 year ago

alanking commented 1 year ago

Addresses #143 Addresses #144

Decided that just printing sha after the whole test run is probably best for now (rather than for each executor). If the need arises in the future, we can do something like that.

korydraughn commented 1 year ago

Excellent. I agree on the handling of the SHA.

Has the database logic for a remote docker daemon been tested? Do you need someone to verify it works?

alanking commented 1 year ago

I have not verified this using a remote docker daemon, just that the local daemon case continues to work. I'm willing to test it out myself (soon, but not right now), although I wouldn't be sad if somebody else verified that these changes address the database service timeout issue :)

korydraughn commented 1 year ago

Sure, I can give it try.

trel commented 1 year ago

sweeeet.

korydraughn commented 1 year ago

It works.

I was able to run unit tests on a remote VM without any modifications to scripts. The version and SHA were printed to the terminal as well.