search

irods / irods_testing_environment

BSD 3-Clause "New" or "Revised" License
8 stars 14 forks source link

Building ubuntu:18.04 projects fails #156

Closed alanking closed 1 year ago

alanking commented 1 year ago

Here's the error message:

...
Step 7/9 : RUN python3 -m pip install unittest-xml-reporting &&     python2 -m pip install xmlrunner
 ---> Running in b7579401efbc
Collecting unittest-xml-reporting
  Downloading https://files.pythonhosted.org/packages/8c/28/f3d33f5725f4b84673ffe420bfa313f6f422d379a7d725bc7d898db45f3c/unittest_xml_reporting-3.1.0-py2.py3-none-any.whl
Collecting lxml (from unittest-xml-reporting)
  Downloading https://files.pythonhosted.org/packages/06/5a/e11cad7b79f2cf3dd2ff8f81fa8ca667e7591d3d8451768589996b65dec1/lxml-4.9.2.tar.gz (3.7MB)
    Complete output from command python setup.py egg_info:
    Building lxml version 4.9.2.
    Building without Cython.
    Error: Please make sure the libxml2 and libxslt development packages are installed.

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-eiksm4wc/lxml/
The command '/bin/sh -c python3 -m pip install unittest-xml-reporting &&     python2 -m pip install xmlrunner' returned a non-zero code: 1
ERROR: Service 'irods-catalog-provider' failed to build : Build failed

The pertinent fix seems to be given to us here:

Please make sure the libxml2 and libxslt development packages are installed.

alanking commented 1 year ago

Perhaps a separate issue, but I believe that this issue would have been avoided if we pinned the version of unittest-xml-reporting being installed via pip. This dependency is new.

d-w-moore commented 1 year ago

Maybe - not sure if it's better to pin, or let the OS determine when an updated unittest-xml-reporting is called for. Since this works for now, I'm happy...

alanking commented 1 year ago

Well, unfortunately, the OS is not determining the version, but pip is. If we used the OS-provided packages this would be avoided, but I believe I ran into issues when trying to locate and/or install those for some if not all platforms. Feel free to play around with it, or just provide the minimal fix that we found today and we'll cross that bridge when we get to it.

d-w-moore commented 1 year ago

Ok. for now, I'll verify tests pass on Ub18 with the current unittest-xml-reporting version, then and pin it at that version. If that seems right.

alanking commented 1 year ago

Yes, good plan.