search

irods / irods_testing_environment

BSD 3-Clause "New" or "Revised" License
8 stars 15 forks source link

Remove mysql 5.7 projects #169

Closed SwooshyCueb closed 6 months ago

SwooshyCueb commented 1 year ago

Given that 4.2 has seen its last release and 4.3 requires UTF-8 in the db, we can remove the mysql 5.7 projects now.

korydraughn commented 1 year ago

What's the recommendation for people needing to test/use a version of 4.2?

It's not uncommon to spin up an earlier version of iRODS to compare behavior. I think 4.2 only works with MySQL 5.7.

SwooshyCueb commented 1 year ago

My recommendation would be to check out the commit before 5.7 is removed.

korydraughn commented 1 year ago

That's fine given we use git.

Perhaps we should apply a tag to mark where 4.2 support ends. Then no one has to search for the commit if they need it.

Thoughts?

trel commented 1 year ago

That seems useful.

No new 4.2-specific things are expected to ever land here, so marking our current tip of main as 4.2-end-of-support (or something similar) seems okay/good.

Please suggest tag-names here...

trel commented 1 year ago

we should consider the same for https://github.com/irods/irods_development_environment/

korydraughn commented 1 year ago

The tag you suggested seems fine. Alternatively we use the abbreviated form (i.e. 4.2-EOL) with the assumption that many devs tend to use EOL as a search term.

trel commented 1 year ago

4.2-EOL seems fine. Have to make sure it’s not confusing which commit is the last good one vs the first one that breaks compatibility.

korydraughn commented 1 year ago

I'm fine with the one you came up with. All we need is a small section in the README that explains how to find the tag and the scheme we use.

trel commented 1 year ago

Agreed. We’ve almost done this for past releases / thresholds but it was never clear as we added new externals before we knew an older thing was going away or already didn’t work as expected.