irods / python-irodsclient

A Python API for iRODS
Other
62 stars 72 forks source link

[#519] correct regression with server_verify_mode of "none" #530

Closed d-w-moore closed 2 months ago

d-w-moore commented 2 months ago

Seems good. Has this been tested?

These changes were tested pre-review but not yet post-review. Likely I'll wait until after we've reviewed a few more PR's as a team and I've tested the changes all together, then we'll merge them all at once. That is just the more efficient way to do it at the moment, given the changes to the testing process that are in store for PRC v2.1.0

korydraughn commented 2 months ago

That sounds more error prone since you're handling multiple PRs, but if you feel that's the most efficient way to handle it on your end, then proceed.

d-w-moore commented 2 months ago

That sounds more error prone since you're handling multiple PRs, but if you feel that's the most efficient way to handle it on your end, then proceed.

I felt it was the most efficient, if not overall best, way. But I don't think it adds any extra opportunity for error, any more than the requisite Git mechanics.

d-w-moore commented 2 months ago

Changing commit message to exclude #281 in head-line per https://github.com/irods/python-irodsclient/pull/508#issuecomment-1997374473

d-w-moore commented 2 months ago

Tested and passing. To resolve "critical" codacy comment (re unexpected parameter ssl_dir) this PR should follow #527 in the merge order.

korydraughn commented 2 months ago

Squash to taste if ready, no pounds.

We'll hold on merging this one until #527 is merged.