search

irods / python-irodsclient

A Python API for iRODS
Other
62 stars 72 forks source link

[#525] Add support for touch API operation #531

Closed korydraughn closed 3 weeks ago

korydraughn commented 3 months ago

The implementation appears to work.

Just need to implement tests.

trel commented 3 months ago

Why all caps error code? Is there precedent for that in PRC?

korydraughn commented 3 months ago

Just not familiar with all the conventions yet. Also, I think I saw exceptions like that used in other places in the PRC.

d-w-moore commented 3 months ago

Why all caps error code? Is there precedent for that in PRC?

I don't know the valid uses of INVALID_OBJECT_TYPE , either. Not currently used otherwise, so may be a relic of something in PRC's past that got deleted. It appears also that it subclasses RuleEngineException, which may be misleading. I would suggest another error (possibly more targeted? Invalid_Path_For_Object_Type?)

korydraughn commented 3 months ago

I added a new exception type, InvalidInputArgument, to replace the use of INVALID_OBJECT_TYPE.

All new tests pass. The only way I could run my tests was by skipping the iRODS version check code in helpers.make_session(). Is there another way to handle that?

korydraughn commented 3 months ago

Forgot to mention this PR also adds modify_time and create_time to the replica object. See https://github.com/irods/python-irodsclient/pull/531/commits/aad7740bca85101a5f79c9f56b5c3a72b5eff112.

korydraughn commented 3 months ago

Looks like I need to address a few more codacy issues.

korydraughn commented 1 month ago

All review comments addressed.

All that's left is to run the full test suite.

korydraughn commented 3 weeks ago

Squashed.

korydraughn commented 3 weeks ago

Running full test suite to make sure nothings broken.

Will pound if everything comes out good.

korydraughn commented 3 weeks ago

I saw 2 failures and 46 errors. Not sure what to expect.

@d-w-moore Any thoughts? Please try running this PR through the test suite and see what you get.

d-w-moore commented 3 weeks ago

I saw 2 failures and 46 errors. Not sure what to expect.

@d-w-moore Any thoughts? Please try running this PR through the test suite and see what you get.

Sure, will run now.

d-w-moore commented 3 weeks ago

I saw 2 failures and 46 errors. Not sure what to expect. @d-w-moore Any thoughts? Please try running this PR through the test suite and see what you get.

Sure, will run now. Got 13 errors from the entire suite. (270 tests run), running against iRODS 4.3.2. All 13 accounted for by:

  • errors coming from login_auth_test.py. It requires specific setups, so shouldn't be run as a matter of course in the PRC suite. Unfortunate bad form on that one, mea culpa. That will be fixed this next release (see issue #502. we'll be renaming it to run in a BATS test and that should defeat the pattern matching that causes it to be picked up in the routine run of the full suite).
  • irods.message.Bad_AVU_Value should be descended from ValueError for irods.test.meta_test.TestMeta.test_add_obj_meta_empty to pass.

@korydraughn - For other errors you may have seen, we should discuss live. Do you have a log dump?

korydraughn commented 3 weeks ago

Excellent.

'd