search

irods / python-irodsclient

A Python API for iRODS
Other
62 stars 72 forks source link

[543] Fix issue with parallel downloads to a directory #544

Closed qubixes closed 2 months ago

qubixes commented 2 months ago

See the linked issue for more details on what this PR fixes. I don't know if there are any side effects.

We tried it out with our ibridges client and it fixes the issue a user had.

Addresses #543

trel commented 2 months ago

looks good by inspection.

korydraughn commented 2 months ago

Thanks for the contribution.

We need a test for this. You can take a swing at it or we can write one for you.

Do you have a preference?

qubixes commented 2 months ago

@trel @korydraughn Thanks!

I have modified the test_obj_put_get test and split it into two tests: one for small and one for large (as determined by the switch to parallel transfers). Does that work for you?

I haven't tested it locally, since I don't have a local iRODS server setup. If it's necessary I can try to create one at some point, but then it might be a bit longer.

korydraughn commented 2 months ago

Does that work for you?

That's fine.

Given you don't have a local server for testing, we will write a test for your PR.

You'll still get credit too. Thanks.

qubixes commented 2 months ago

@korydraughn Thanks! I think the test I wrote should fail without the fix (and pass now), but perhaps you had something else in mind? Either way, I will leave it up to you then.