irods / python-irodsclient

A Python API for iRODS
Other
63 stars 73 forks source link

[#569] fix stored connections to match desired connection timeout #570

Closed d-w-moore closed 2 months ago

d-w-moore commented 3 months ago

Needs a test or two.

(Tests should include evaluating whether the new code works for SSL sockets.)

d-w-moore commented 2 months ago

This is ready for review.

d-w-moore commented 2 months ago

(Tests should include evaluating whether the new code works for SSL sockets.)

The SSL test for this should come as part of a different PR. Reason being : it depends on some test infrastructure that is not merged for this release and may indeed have to wait for a subsequent one.

alanking commented 2 months ago

Are the open conversations handled? It looked like they were last time I checked, but they have not been resolved, so I wanted to make sure.

d-w-moore commented 2 months ago

Are the open conversations handled? It looked like they were last time I checked, but they have not been resolved, so I wanted to make sure.

Yes indeed-y.