search

irods / python-irodsclient

A Python API for iRODS
Other
62 stars 73 forks source link

[#586] implement xml_mode for temporary parser changes #589

Closed d-w-moore closed 3 months ago

alanking commented 4 months ago

Created a couple new issues for some of my comments. I left the others unresolved in case there was more to do, but they look like they can be resolved to me.

trel commented 4 months ago

so i think we're ready to squash em, no #s.

alanking commented 4 months ago

Yes, agreed. Consider addressing Codacy comments as well. Some unused / re-imported imports, apparently.

d-w-moore commented 4 months ago

so i think we're ready to squash em, no #s.

Squashed . Do we want mention of with xml_mode(...):in the README?

alanking commented 4 months ago

Good point. Yes, let's document that. I think this section would be a good place to mention it, perhaps: https://github.com/irods/python-irodsclient?tab=readme-ov-file#special-characters

d-w-moore commented 4 months ago

README modification and additions have been made

d-w-moore commented 4 months ago

Tests are passing.

alanking commented 3 months ago

@d-w-moore - # when ready. Or, please let us know of what else needs to be done for this PR. Thanks

d-w-moore commented 3 months ago

# when ready. Or, please let us know of what else needs to be done for this PR. Thanks

Done! Pound added.