irods / python-irodsclient

A Python API for iRODS
Other
62 stars 73 forks source link

Change `unittest.skipIf` decorator into an assertion for some tests #591

Open alanking opened 4 months ago

alanking commented 4 months ago

From these review comments: https://github.com/irods/python-irodsclient/pull/589#discussion_r1686611670 and https://github.com/irods/python-irodsclient/pull/585#discussion_r1684567214

These tests will be skipped if the environment in which the test is running is not found to be in the expected state. This could lead to the test being skipped unintentionally. If we want the test to always be run, we should assert that the environment has the expected conditions rather than skipping the test. Skipping the test could lead us to believe that all our tests are passing when in fact they are not, just because the testing environment is not in the expected state.