irods / python-irodsclient

A Python API for iRODS
Other
62 stars 73 forks source link

Some test and test infrastructure fixes and improvements #601

Closed alanking closed 4 months ago

alanking commented 4 months ago

Addresses #566 (I think) Addresses #597 (via two alternatives)

The #566 solution seemed the most expedient, and we will need to revisit that one as part of the effort for #502. Willing to work on the name.

The #597 commits are alternatives, so we need to pick one. The options are:

  1. Remove the Postgres-specific SQL assertions
  2. Change the SQL assertions to just look for a table name to make sure it's some form of actual SQL

I do not have a preference for 1 or 2 over the other. I kind of feel like the assertion is only there to assert that something is returned. The specifics of the contents seems more like the job of the GenQuery2 parser and/or API as far as testing goes, IMO.

Test suite as determined by irods/test/runner.py now passes running against iRODS 4.3.2 with postgres and mysql.

korydraughn commented 4 months ago

Let's go with option 2 for #597. That is, assert that the SQL contains an expected table name. At the very least, it proves that the API is returning something.

alanking commented 4 months ago

If there are no further comments, I'll squash this down to two commits which would include the table name assertions (option 2).

alanking commented 4 months ago

Oops, I mean 3 commits. 1 for the login_auth_test rename, 1 for the genquery2_test, and 1 for commenting out the BETWEEN tests.

korydraughn commented 4 months ago

If you're happy with it, squash to taste.

alanking commented 4 months ago

Squashed

alanking commented 4 months ago

'd. Mergin.