search

irods / python-irodsclient

A Python API for iRODS
Other
62 stars 73 forks source link

[#614] schedule execution of functions at and around PRC close-down #616

Open d-w-moore opened 3 months ago

d-w-moore commented 1 week ago

Wondering if the *_PRCsymbols should be renamed to be more specific, more indicative of what they refer to. Maybe: BEFORE_PRC_CLEANUP, DURING_PRC_CLEANUP, AFTER_PRC_CLEANUP. Any thoughts?

trel commented 1 week ago

was wondering about that too. we call it PRC verbally... but we don't really... have that in writing in the code? hmmm.

yes, happy to entertain other names.

trel commented 1 week ago

well, that's not apparently true - it's at the VERY TOP of the README

d-w-moore commented 1 week ago

The lingo can be too ingrained, I guess. Maybe a discussion is due on that topic too.

But past that, w.r.t. the names of the 3 cleanup stages themselves, I was wondering whether *_CLEANUP should be the form. Whatever is true of "PRC", BEFORE_PRC isn't really clear enough. Before PRC what? Cleanup, in this case.

Although tbh, BEFORE_PYTHON_IRODSCLIENT_CLEANUP is a bit too long for my tastes.

trel commented 1 week ago

I think BEFORE_PRC_CLEANUP, DURING_PRC_CLEANUP, AFTER_PRC_CLEANUP are fine.