irods / python-irodsclient

A Python API for iRODS
Other
62 stars 73 forks source link

connection timeouts for iRODSSession have a maximum practical value #623

Closed d-w-moore closed 1 month ago

d-w-moore commented 1 month ago

Beyond a value of 9223372036.854775 seconds - around 290 years - large connection timeouts tend to blow up on actual use.

This is actually more of a Python library or OS-related issue, but it behooves us to handle it in PRC as well. So I propose we hard-limit it at the maximum value and log a warning that this action was taken.

See also the source issue for this one.

trel commented 1 month ago

it's such a long time... let's just pick an int that is 290 years (or less)... and be done with it. that's not a reasonable value for a session anyway, so we're just protecting users of the library.

alanking commented 1 month ago

@d-w-moore - Please close if complete. Thanks