irods / python-irodsclient

A Python API for iRODS
Other
62 stars 73 forks source link

Convert changelog to markdown file, record 0.6.0 changes (main) #636

Closed korydraughn closed 1 month ago

korydraughn commented 1 month ago

Merge once @alanking and @d-w-moore report PRC and Ingest tests (w/ PRC tip-of-main) pass.

trel commented 1 month ago

please also look at setup.cfg... i think it should point to README.md

trel commented 1 month ago

and look at MANIFEST.in

trel commented 1 month ago

and AUTHORS

trel commented 1 month ago

and consider removing the auto-generator... .gitchangelog.rc

korydraughn commented 1 month ago

What do you want to do about the AUTHORS file? Doesn't add any value IMO. People can always find it in the git history.

korydraughn commented 1 month ago

I think the AUTHORS file can be removed.

trel commented 1 month ago

I think the AUTHORS file can be removed.

Agreed.

trel commented 1 month ago

i think all these commits are 'packaging' and should be issue 3 ?

trel commented 1 month ago

removing .gitchangelog.rc could be 5... or also 3.

korydraughn commented 1 month ago

Okay. Will make all of them 3.

korydraughn commented 1 month ago

Squashed and reordered.

Did not include recent changes (e.g. AUTHORS file removal) in changelog because the changelog is supposed to highlight notable changes.

korydraughn commented 1 month ago

Fixed it!

d-w-moore commented 1 month ago

Tests pass on tip of main, with the exception of test_assigning_session_connection_timeout_to_invalid_values__issue_569 which just needs float('Inf') removed as a test value

alanking commented 1 month ago

@d-w-moore - https://github.com/irods/python-irodsclient/pull/638 was merged earlier today, so that issue should be resolved now.

I will also confirm that ingest tests were passing when running with a pip package based on commit https://github.com/irods/python-irodsclient/commit/dcd6c135c81b8fba16f3fda4b7e7fcc1f5b012bf. The only difference between tip of main and that commit is the aforementioned removal of float(Inf) from a test, which should not have any effect on ingest.

korydraughn commented 1 month ago

'd