iron-fish / ironfish

A novel cryptocurrency focused on privacy and accessibility.
https://ironfish.network
Mozilla Public License 2.0
964 stars 579 forks source link

Many duplicate minig requests on own node solo mining #3813

Open hostingnuggets opened 1 year ago

hostingnuggets commented 1 year ago

What happened?

I just installed my own v1.0.0 ironfish node on Linux to mine in solo on the main net with a test rig of 2 AMD 6500XT GPUs using TeamRedMiner v0.10.10 and noticed that my ironfish mining pool shows quite a lot of submitted duplicate mining requests. The TeamRedMiner itself on the mining rig does not show any issues and only has accepted shares so far.

Could this be a bug in the ironfish mining pool code?

Version

v1.0.0

Debug output

Iron Fish library               1.0.0 @ 79e7e05
Operating system                Linux x64
CPU model(s)                    AMD Ryzen 9 7950X 16-Core Processor
CPU threads                     32
RAM total                       30.50 GiB
Heap total                      3.99 GiB
Node version                    v18.16.0
ironfish in PATH                true
Garbage Collector Exposed       false
Telemetry enabled               false
Node name                       
Block graffiti

Relevant log output

Client 2 submitted a duplicate mining request: 139, ed09fdea00000009
Client 2 submitted a duplicate mining request: 139, ed09fdea00000009

Graffiti

No response

bossinis commented 1 year ago

I have the same issue cant seem to solve it

hofnars commented 1 year ago

It disappeared for me after increasing the poolDifficulty to something more reasonable than the default.

hostingnuggets commented 1 year ago

@hofnars how much did you increase it to? and what was the command you used for that? I don't find this documented anywhere.

hofnars commented 1 year ago

ironfish config:set poolDifficulty "150000000000"

You can change any parameter in your config with that. I just added a 0 to the default setting to get to the # above. Figured the miner was flooding the pool with requests based on the amount of shares.

https://ironfish.network/use/get-started/cli-commands

bossinis commented 1 year ago

Yes after a little research i found that was the problem.

Still can't see the miners hash into the pool so i give it up

hostingnuggets commented 1 year ago

@hofnars I now set my poolDifficulty to 150 GH as you mentioned and don't see any duplicate mining request message anymore. TeamRedMiner reports the shares as being submitted as you can see below:

[2023-04-23 21:59:02] Pool 192.168.4.4 share submitted. (GPU0) (a:7 r:0) (diff 306.76 GH)
[2023-04-23 21:59:04] Pool 192.168.4.4 share submitted. (GPU1) (a:8 r:0) (diff 164.03 GH)

But I never see any messages about the share being accepted. Is this normal?

induscomp commented 1 year ago

@hofnars I now set my poolDifficulty to 150 GH as you mentioned and don't see any duplicate mining request message anymore. TeamRedMiner reports the shares as being submitted as you can see below:

[2023-04-23 21:59:02] Pool 192.168.4.4 share submitted. (GPU0) (a:7 r:0) (diff 306.76 GH)
[2023-04-23 21:59:04] Pool 192.168.4.4 share submitted. (GPU1) (a:8 r:0) (diff 164.03 GH)

But I never see any messages about the share being accepted. Is this normal?

Same problem here. No accepted shares on my pool. Any solution for this?

nvillamor commented 1 year ago

Same problem here!

diabolicdesigns commented 1 year ago

I have the exact same issue on my node. Duplicate mining requests, No pending shares or hashrate in "miners:pools:status" no indication of shares being accepted in the miner. Doesn't seem to effect all miners. miners that weren't effected (and also had the lowest hashrates) bzminer, srbminer. This issue was present in TeamRed miner and lolminer

diabolicdesigns commented 1 year ago

I could be wrong, but I believe the issue here is that the built-in Ironfish mining pool doesn't support stratum v2 which is what the current miners and pools are using as some of the miners complain about errors such as Rigel.

marioestonia commented 1 year ago

ironfish config:set poolDifficulty "150000000000"

You can change any parameter in your config with that. I just added a 0 to the default setting to get to the # above. Figured the miner was flooding the pool with requests based on the amount of shares.

https://ironfish.network/use/get-started/cli-commands

wath is the deafult diff?

marioestonia commented 1 year ago

Same problem here!

I have the exact same issue on my node. Duplicate mining requests, No pending shares or hashrate in "miners:pools:status" no indication of shares being accepted in the miner. Doesn't seem to effect all miners. miners that weren't effected (and also had the lowest hashrates) bzminer, srbminer. This issue was present in TeamRed miner and lolminer

can you fix it?

marioestonia commented 1 year ago

What happened?

I just installed my own v1.0.0 ironfish node on Linux to mine in solo on the main net with a test rig of 2 AMD 6500XT GPUs using TeamRedMiner v0.10.10 and noticed that my ironfish mining pool shows quite a lot of submitted duplicate mining requests. The TeamRedMiner itself on the mining rig does not show any issues and only has accepted shares so far.

Could this be a bug in the ironfish mining pool code?

Version

v1.0.0

Debug output

Iron Fish library               1.0.0 @ 79e7e05
Operating system                Linux x64
CPU model(s)                    AMD Ryzen 9 7950X 16-Core Processor
CPU threads                     32
RAM total                       30.50 GiB
Heap total                      3.99 GiB
Node version                    v18.16.0
ironfish in PATH                true
Garbage Collector Exposed       false
Telemetry enabled               false
Node name                       
Block graffiti

Relevant log output

Client 2 submitted a duplicate mining request: 139, ed09fdea00000009
Client 2 submitted a duplicate mining request: 139, ed09fdea00000009

Graffiti

No response

same here! anyone got it work?

marioestonia commented 1 year ago

It disappeared for me after increasing the poolDifficulty to something more reasonable than the default.

what is deafult diff? ty

michaelijah commented 7 months ago

I could be wrong, but I believe the issue here is that the built-in Ironfish mining pool doesn't support stratum v2 which is what the current miners and pools are using as some of the miners complain about errors such as Rigel.

Thanks! This was the problem for me. In my hiveos flightsheet (or whatever your client is), I changed my url from ip_address_of_pool:port_of_pool to stratum+tcp://ip_address_of_pool:port_of_pool. I'm assuming hiveos is defaulting to stratum v2 and is trying to connect to stratum2+tcp:// instead of stratum+tcp:// when the stratum protocol isn't explicitly supplied.

EDIT: To be clear, increasing the difficulty got rid of the duplicate warnings. Prepending stratum+tcp:// before the pool url in my miner allowed me to mine to my solo pool.