iron-fish / ironfish

A novel cryptocurrency focused on privacy and accessibility.
https://ironfish.network
Mozilla Public License 2.0
962 stars 576 forks source link

Move wallet scanning code into WalletScanner #4983

Closed NullSoldier closed 1 month ago

NullSoldier commented 2 months ago

Summary

This new wallet scanner tries to move some of the code (excluding decryption) into a new class called the WalletScanner. This will act as the holding ground for new scanning related code. This doesn't exactly clean up a lot of the code, but does start as the beginning of an attempt to simplify the scanning code.

Fixes IFL-2570

Testing Plan

  1. Start scanning
  2. Cause rescan
  3. Disable an account
  4. Start another rescan

Documentation

[X] Yes

Documentation added here https://github.com/iron-fish/website/pull/704

Breaking Change

[x] Yes
dguenther commented 1 month ago

This needs doc changes at least queued up before it goes in I think