iron-fish / ironfish

A novel cryptocurrency focused on privacy and accessibility.
https://ironfish.network
Mozilla Public License 2.0
962 stars 576 forks source link

Prompt for expiration sequence when creating raw or unsigned transactions in CLI #4988

Closed dguenther closed 2 months ago

dguenther commented 2 months ago

Summary

Users will typically want to specify an expiration sequence when creating a raw or unsigned transaction, as otherwise by default they'll have 15 blocks to submit the transaction, which may not be long enough to sign it and submit it.

The check is optional, so if users leave the prompt blank, it'll use the default.

Testing Plan

Manually tested:

image

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API Reference)? If yes, link a related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.

[ ] Yes