some wallet commands take 'account' as a positional argument when it may make more sense as a flag.
adds account flag to commands that list things for an account: assets, balances, notes, transactions
adds account flag where commands are oriented around a transaction rather than an account: wallet:transaction, wallet:transaction:watch
parse flags and args so that account flag is preferred, but account arg still accepted
updates arg description to display that argument is deprecated
Testing Plan
manual testing
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
[ ] Yes
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.
Summary
some wallet commands take 'account' as a positional argument when it may make more sense as a flag.
adds account flag to commands that list things for an account: assets, balances, notes, transactions
adds account flag where commands are oriented around a transaction rather than an account: wallet:transaction, wallet:transaction:watch
parse flags and args so that account flag is preferred, but account arg still accepted
updates arg description to display that argument is deprecated
Testing Plan
manual testing
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API Reference)? If yes, link a related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.