search

iron-fish / ironfish

A novel cryptocurrency focused on privacy and accessibility.
https://ironfish.network
Mozilla Public License 2.0
962 stars 576 forks source link

supports combining notes for custom assets #5005

Closed hughy closed 1 month ago

hughy commented 1 month ago

Summary

adds an assetId flag to the 'wallet:notes:combine' command

command prompts user to select asset if no asset is specified

displays output notes (including any change note) from the resulting transaction

does not truncate output in table displaying combined notes so that asset information isn't truncated

Testing Plan

manual testing:

image

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API Reference)? If yes, link a related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.

[ ] Yes
patnir commented 1 month ago

Tested it out by combining a custom asset and it worked great