search

iron-fish / ironfish

A novel cryptocurrency focused on privacy and accessibility.
https://ironfish.network
Mozilla Public License 2.0
962 stars 576 forks source link

Feat: abort scanning asap if needed during reset account #5006

Closed hairtail closed 1 month ago

hairtail commented 1 month ago

Summary

Testing Plan

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API Reference)? If yes, link a related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.

[ ] Yes
dguenther commented 1 month ago

We talked through this in Telegram -- this isn't the intended use of resetScanningEnabled, rather it's supposed to set scanningEnabled back to its default value (true). But I'll talk with @NullSoldier about the idea of changing it to setScanningEnabled