iron-fish / ironfish

A novel cryptocurrency focused on privacy and accessibility.
https://ironfish.network
Mozilla Public License 2.0
962 stars 576 forks source link

moves block connect/disconnect logic into account #5008

Open hughy opened 1 month ago

hughy commented 1 month ago

Summary

removes 'connectBlockForAccount' and 'disconnectBlockForAccount' methods from Wallet class and moves that logic to the Account class

delegates management of account data in the walletdb to the account

removes the 'upsertAssetsFromDecryptedNotes' and instead uses the 'backfillAssets' method for each block. this is consistent with how we backfill assets for pending transactions

Testing Plan

existing unit tests

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API Reference)? If yes, link a related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.

[ ] Yes