I have no idea why these types were introduced, but they were not necessary. You can just use the basic primitives we already have and not introduce brand new types to the code base.
There will be further changes to delete the initial index calculation and push it further down to the place where you actually loop over the transactions.
Testing Plan
Existing tests cover the scanning and chain processor.
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
[ ] Yes
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.
Summary
I have no idea why these types were introduced, but they were not necessary. You can just use the basic primitives we already have and not introduce brand new types to the code base.
There will be further changes to delete the initial index calculation and push it further down to the place where you actually loop over the transactions.
Testing Plan
Existing tests cover the scanning and chain processor.
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API Reference)? If yes, link a related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.