search

iron-fish / ironfish

A novel cryptocurrency focused on privacy and accessibility.
https://ironfish.network
Mozilla Public License 2.0
963 stars 574 forks source link

Remove RemoteChainProcessor calculating noteIndex #5027

Closed NullSoldier closed 3 months ago

NullSoldier commented 3 months ago

Summary

This was only used in a few places, and it's better for people down the callstack to calculate this since they are also given the header as well.

This is easier to review with https://github.com/iron-fish/ironfish/pull/5027/files?diff=split&w=1

Testing Plan

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API Reference)? If yes, link a related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.

[ ] Yes