oclif already trims by default. By adding these trims, we're overriding the behavior of oclif and closing unintentional escape hatches for cases where a leading/trailing space might be intended when wrapping the arg or flag in quotation marks.
There are a few more places where trim is being used in the CLI commands, but they are generally being used as part of more complex split functions, or are deep enough down the call stack that I didn't want to potentially cause issues for now.
Summary
oclif already trims by default. By adding these trims, we're overriding the behavior of oclif and closing unintentional escape hatches for cases where a leading/trailing space might be intended when wrapping the arg or flag in quotation marks.
There are a few more places where
trim
is being used in the CLI commands, but they are generally being used as part of more complex split functions, or are deep enough down the call stack that I didn't want to potentially cause issues for now.Testing Plan
Documentation
N/A
Breaking Change
N/A