iron-fish / ironfish

A novel cryptocurrency focused on privacy and accessibility.
https://ironfish.network
Mozilla Public License 2.0
964 stars 577 forks source link

Rename isHexEncoding to be more clear #5035

Closed NullSoldier closed 4 weeks ago

NullSoldier commented 1 month ago

Summary

This function isn't checking if you have allowed characters, its specifically checking if a string is hex encoded. This makes it more clear.

Testing Plan

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API Reference)? If yes, link a related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.

[ ] Yes