This fixes the fact that we attempted to add encryption to our encoder
itself, but it was nerver fully inserted into the encoding because the
decoding flow never used the wallet to try all the secrets. This means
the encryption of an encoded account was only half in the encoding
system, and half out.
This introduces a very clear separate module at
Wallet/Exporter/Encryption which has all the methods to handle
encryption.
Testing Plan
Added new tests
Revised old tests
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
[ ] Yes
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.
Summary
This fixes the fact that we attempted to add encryption to our encoder itself, but it was nerver fully inserted into the encoding because the decoding flow never used the wallet to try all the secrets. This means the encryption of an encoded account was only half in the encoding system, and half out.
This introduces a very clear separate module at Wallet/Exporter/Encryption which has all the methods to handle encryption.
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API Reference)? If yes, link a related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.