iron-fish / ironfish

A novel cryptocurrency focused on privacy and accessibility.
https://ironfish.network
Mozilla Public License 2.0
964 stars 579 forks source link

Use `inquirer` for confirm prompt #5061

Closed mat-if closed 2 weeks ago

mat-if commented 2 weeks ago

Summary

This also creates an abstraction for the confirm prompt as well as a confirm-or-quit function so it is easier to use confirm logic in commands

This is part of oclif 4.x upgrade prep

Trade-offs

We're trading our manually-added "Do you confirm (Y)es/(N)o" for the library appended "(Y/n)". There is no easy way to override this, short of upgrading the version of inquirer we use. However, the new version of inquirer is an ECMAScript Module, which on its own is solvable, but on top of that, the @types/inquirer library is quite outdated, which would require us to write our own types to use it, which is more work than it is worth right now.

image

Testing Plan

Manual testing

Documentation

N/A

Breaking Change

N/A