iron-fish / ironfish

A novel cryptocurrency focused on privacy and accessibility.
https://ironfish.network
Mozilla Public License 2.0
964 stars 579 forks source link

Revert "Have WalletScanner use chain directly if available" #5065

Closed NullSoldier closed 1 week ago

NullSoldier commented 1 week ago

Reverts iron-fish/ironfish#5063

The reason for this revert, is that the ChainProcessor does not implement pagination in the same way that the RemoteChainProcessor does. This creates an issue where the ChainProcessor eagerly decrypts the whole chain. There are external components that used to rely on the remote chain processor pausing every page and "completing". Because of that, I'll be reverting this and re-introducing this with that change to make it compatible with the RemoteChainProccessor.

linear[bot] commented 1 week ago

Issue reopened: IFL-2657 Prefer using ChainProcessor in place of RemoteChainProcessor during wallet rescans