iron-fish / ironfish

A novel cryptocurrency focused on privacy and accessibility.
https://ironfish.network
Mozilla Public License 2.0
964 stars 579 forks source link

Simplify ChainProcessor return logic #5073

Closed NullSoldier closed 1 week ago

NullSoldier commented 1 week ago

Summary

We only ever cared if work was done, not that the specific hash was changed from the original. This does change the behaviour, but I looked at everywhere it's used and it should not affect the overall behaviour.

Testing Plan

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API Reference)? If yes, link a related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.

[ ] Yes