search

iron-fish / ironfish

A novel cryptocurrency focused on privacy and accessibility.
https://ironfish.network
Mozilla Public License 2.0
964 stars 579 forks source link

defines TransactionalDatabase to reuse withTransaction #5091

Closed hughy closed 1 week ago

hughy commented 1 week ago

Summary

moves the 'transaction' and 'withTransaction' methods from the abstract 'Database' class into a separate 'TransactionalDatabase' class

BlockchainDB extends TransactionalDatabase to allow it to reuse the implementation of 'withTransaction'

changes 'BlockchainDBTransaction' type annotations back to IDatabaseTransaction

Testing Plan

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API Reference)? If yes, link a related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.

[ ] Yes