iron-fish / ironfish

A novel cryptocurrency focused on privacy and accessibility.
https://ironfish.network
Mozilla Public License 2.0
964 stars 579 forks source link

ensures that postTransaction uses a spending account #5092

Open hughy opened 1 week ago

hughy commented 1 week ago

Summary

replaces 'getAccountByPublicAddress' with a more generic 'findAccount' that takes a predicate

uses findAccount in postTransaction to find the account that has the same public address and is a spending account

fixes issue where wallet has a spending account and a view only account with the same public address and cannot post a transaction

Testing Plan

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API Reference)? If yes, link a related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.

[ ] Yes