search

iron-fish / ironfish

A novel cryptocurrency focused on privacy and accessibility.
https://ironfish.network
Mozilla Public License 2.0
964 stars 579 forks source link

wallet/adSignature: RPC to add signature to a transaction. #5097

Closed patnir closed 4 days ago

patnir commented 4 days ago

Summary

This RPC is used to add signature to a transaction. It takes a transaction and a signature as input and returns a signed transaction.

Testing Plan

Unit tests.

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API Reference)? If yes, link a related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.

[ ] Yes
patnir commented 4 days ago

LGTM, not sure if you want to include broadcast logic as part of this RPC. I generally like having this stuff be composable, ie addSignature -> addTransaction

Sounds good, I'll take that approach. Removed the broadcast flag