iron-fish / ironfish

A novel cryptocurrency focused on privacy and accessibility.
https://ironfish.network
Mozilla Public License 2.0
962 stars 576 forks source link

Rahul/ifl 2746 wallet sign command #5111

Closed patnir closed 3 weeks ago

patnir commented 3 weeks ago

Summary

Adds the wallet:sign CLI command along with the wallet/signTransaction RPC.

We already have a sign function on an UnsignedTransaction on the Rust side. This basically exposes that feature.

Also included is the ledger signing option for this CLI command.

Testing Plan

Manually tested signing an unsigned transaction and adding (wallet:transaction:add) the signed transaction using both an account with a spending key and an account that is a ledger device.

Documentation

To follow in a separate PR on the website

Does this change require any updates to the Iron Fish Docs (ex. the RPC API Reference)? If yes, link a related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.

[ ] Yes