search

iron-fish / ironfish

A novel cryptocurrency focused on privacy and accessibility.
https://ironfish.network
Mozilla Public License 2.0
962 stars 576 forks source link

add ledger flag to send command #5122

Closed patnir closed 2 weeks ago

patnir commented 3 weeks ago

Summary

Add --ledger to wallet:send command.

Testing Plan

Send transactions with a ledger device using the --ledger flag with the --watch and --confirm flags. Send a transaction with another account that isn't the ledger account.

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API Reference)? If yes, link a related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.

[ ] Yes
patnir commented 2 weeks ago

Looks good to me!

The only thing I noticed is that the transaction summary that gets printed in the CLI doesn't account for change notes, so the number of outputs there may differ from the number of outputs that you confirm on the Ledger

Sweet, I'll merge and look into the change notes in a separate issue